Move lre-cc into the lre overlay #1529
Conversation
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 9 files reviewed, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Coverage, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache / macos-14, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, Web Platform Deployment / macos-14, Web Platform Deployment / ubuntu-24.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable (waiting on @SchahinRohani)
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Awesome work!
Personally i like that modularity and portability direction for shipping the toolchain with nix!
I am also excited to use lre-rs!
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Bazel Dev / macos-13, Bazel Dev / macos-14, Cargo Dev / macos-13, Coverage, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache / macos-14, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, Web Platform Deployment / macos-14, docker-compose-compiles-nativelink (22.04), macos-13, windows-2022 / stable
This change makes lre-cc more portable and provides the structure into which we can add additional toolchains, like the upcoming lre-rs. The lre-cc logic now automatically registers the "implementation detail" packages automatically. The new command to regenerate lre-cc is now called `lre-cc`.
aaronmondal
force-pushed
the
lre-cc-overlay
branch
from
bdafcfc to
1cc11ed
Compare
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained, and all files reviewed
This change makes lre-cc more portable and provides the structure into which we can add additional toolchains, like the upcoming lre-rs.
The lre-cc logic now automatically registers the "implementation detail" packages automatically.
The new command to regenerate lre-cc is now called
lre-cc.This change is