Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: FileSystemStore to use StoreKey #1528

Closed

Conversation

varshith257
Copy link

@varshith257 varshith257 commented Dec 8, 2024

Description

Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2024

CLA assistant check
All committers have signed the CLA.

@KGrewal1
Copy link
Contributor

KGrewal1 commented Dec 9, 2024

Dear any reviewers, can it please be acknowledged that I have had an open, complete pull request for this bounty for the previous 2 weeks (#1489) with pushes being to keep it up to date with main, with the difference being addition of a solution to needing excess clones for the map. Whilst I appreciate there are only so many ways to come to a solution to this issue and most will inevitably look the same, I would ask that my solution be reviewed. Regards

@allada
Copy link
Member

allada commented Dec 11, 2024

Thanks, but it looks like this PR is going to likely be accepted:
#1489

@aaronmondal
Copy link
Member

Fixed by #1489

@varshith257 varshith257 deleted the refactor/filestore branch December 14, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants