-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lua embedding #1468
Closed
Closed
Add Lua embedding #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrbrain
had a problem deploying
to
production
November 8, 2024 21:40 — with
GitHub Actions
Failure
barrbrain
had a problem deploying
to
production
November 8, 2024 21:41 — with
GitHub Actions
Failure
MarcusSorealheis
requested review from
aaronmondal
and removed request for
aaronmondal
November 9, 2024 00:15
barrbrain
force-pushed
the
lua-script
branch
from
November 11, 2024 12:25
eeea1f2
to
2d55851
Compare
barrbrain
had a problem deploying
to
production
November 11, 2024 12:25 — with
GitHub Actions
Failure
barrbrain
had a problem deploying
to
production
November 11, 2024 12:26 — with
GitHub Actions
Failure
barrbrain
force-pushed
the
lua-script
branch
from
November 11, 2024 14:41
2d55851
to
af33018
Compare
barrbrain
had a problem deploying
to
production
November 11, 2024 14:41 — with
GitHub Actions
Failure
barrbrain
had a problem deploying
to
production
November 11, 2024 14:42 — with
GitHub Actions
Failure
barrbrain
force-pushed
the
lua-script
branch
from
November 12, 2024 15:55
af33018
to
5f0f579
Compare
barrbrain
had a problem deploying
to
production
November 12, 2024 15:56 — with
GitHub Actions
Failure
barrbrain
had a problem deploying
to
production
November 12, 2024 15:57 — with
GitHub Actions
Failure
barrbrain
force-pushed
the
lua-script
branch
from
November 13, 2024 18:02
5f0f579
to
ce8bf19
Compare
barrbrain
had a problem deploying
to
production
November 13, 2024 18:02 — with
GitHub Actions
Failure
barrbrain
had a problem deploying
to
production
November 13, 2024 18:03 — with
GitHub Actions
Failure
barrbrain
force-pushed
the
lua-script
branch
from
November 14, 2024 13:43
ce8bf19
to
272bd18
Compare
barrbrain
had a problem deploying
to
production
November 14, 2024 13:43 — with
GitHub Actions
Failure
barrbrain
had a problem deploying
to
production
November 14, 2024 13:44 — with
GitHub Actions
Failure
barrbrain
force-pushed
the
lua-script
branch
from
November 20, 2024 12:31
272bd18
to
4411d14
Compare
barrbrain
had a problem deploying
to
production
November 20, 2024 12:31 — with
GitHub Actions
Failure
barrbrain
had a problem deploying
to
production
November 20, 2024 12:32 — with
GitHub Actions
Failure
barrbrain
force-pushed
the
lua-script
branch
from
November 20, 2024 14:58
4411d14
to
5591707
Compare
barrbrain
had a problem deploying
to
production
November 20, 2024 14:58 — with
GitHub Actions
Failure
barrbrain
force-pushed
the
lua-script
branch
from
November 20, 2024 15:12
5591707
to
edcdff4
Compare
barrbrain
force-pushed
the
lua-script
branch
from
November 20, 2024 15:27
edcdff4
to
d65a1e7
Compare
Fixed the Bazel build by dropping the |
Closing this draft in favour of a WebAssembly component embedding. The exploration of API shape was informative. |
@barrbrain could you reference this PR in the WebAssembly component embedding? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a minimal Lua interface for interacting with a store. The motivating example transferring data by exercising
FastSlowStore::get_part_unchunked()
.Type of change
How Has This Been Tested?
Checklist
bazel test //...
passes locallygit amend
see some docsThis change is