-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update coverage for error and config packages #1463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained, and 5 of 6 files reviewed, and 1 discussions need to be resolved
nativelink-error/src/lib.rs
line 154 at r1 (raw file):
impl From<prost::DecodeError> for Error { fn from(err: prost::DecodeError) -> Self { Error::new(Code::Internal, err.to_string())
Lets not change this since rest of the code follows this pattern for now.
4789b6f
to
55eba14
Compare
55eba14
to
29f7228
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leodziki the commits would need to be squashed before we could land this
Reviewed 3 of 4 files at r2.
Reviewable status: 0 of 2 LGTMs obtained, and 6 of 7 files reviewed, and pending CI: Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Coverage, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, NativeLink.com Cloud / Remote Cache / macos-14, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, Web Platform Deployment / macos-14, Web Platform Deployment / ubuntu-24.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable, and 1 discussions need to be resolved
ec287ff
to
1cf6365
Compare
Description
Currently, coverage rate has been upgraded to 80-100% in nativelink-error and nativelink-config packages.
Bazel test and cargo test both passed. And Pre-commit passed in direnv and everything is perfect.
Fixes #1401
Type of change
not work as expected)
How Has This Been Tested?
Bazel test, cargo test and pre-commit
Checklist
bazel test //...
passes locallyThis change is