-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aaron's awesome talk to homepage and resource page #1452
base: main
Are you sure you want to change the base?
Add Aaron's awesome talk to homepage and resource page #1452
Conversation
e3a3b34
to
e443598
Compare
e443598
to
952b58c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: consider adding it to the LRE readme https://www.nativelink.com/docs/explanations/lre
❤️
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
web/platform/src/components/qwik/pages/home.tsx
line 19 at r2 (raw file):
<div class="mx-auto left-0 right-0 w-9/11 flex justify-center items-center flex-col gap-4"> <div class="text-sm flex justify-center w-full md:w-9/12 px-8 md:px-0"> An awesome talk of one of TraceMachina's leading engineers Aaron
nit: The text looks out of place on the homepage. Maybe let's just add the video without the text?
Add an iframe to the homepage and resource page linked to the the youtube video: "Hermetic Toolchain Creation with Local Remote Execution (LRE) & Nix" by Aaron Mondal, NativeLink
952b58c
to
e436edc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! 1 of 1 LGTMs obtained, and all files reviewed
Description
Add Aaron Mondals awesome talk on the bazelcon to the homepage and resource page
Checklist
bazel test //...
passes locallygit amend
see some docsThis change is