Support graceful shutdown for network connections #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchahinRohani
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc
allada
force-pushed
the
graceful-shutdown-for-connected-clients
branch
from
28d42d4 to
6c374e3
Compare
allada
force-pushed
the
graceful-shutdown-for-connected-clients
branch
from
6c374e3 to
39db838
Compare
Waits for network connections to close during graceful shutdown.
allada
force-pushed
the
graceful-shutdown-for-connected-clients
branch
from
39db838 to
6292f0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waits for network connections to close during graceful shutdown.
This change is