Removes touch() api from EvictionMap #1428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allada
force-pushed
the
remove-eviction-map-touch-api
branch
from
b6cf345 to
720d707
Compare
allada
commented
Oct 23, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 4 files reviewed, and pending CI: pre-commit-checks (waiting on @SchahinRohani)
The only reason this existed is for FilesystemStore to make it more deterministic when starting up from a cold start, however the overhead of changing the atime on every has() or get() request is a bit excessive so we remove it to reduce the sys calls.
allada
force-pushed
the
remove-eviction-map-touch-api
branch
from
720d707 to
068dea5
Compare
adam-singer
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and all files reviewed, and pending CI: Publish nativelink-worker-init, windows-2022 / stable (waiting on @SchahinRohani)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only reason this existed is for FilesystemStore to make it more
deterministic when starting up from a cold start, however the
overhead of changing the atime on every has() or get() request is
a bit excessive so we remove it to reduce the sys calls.
This change is