-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken demo button link #1404
Fix broken demo button link #1404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
web/platform/src/components/qwik/sections/feature.tsx
line 47 at r1 (raw file):
))} </div> <a
changing this to an a
will change the style, wont it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
web/platform/src/components/qwik/sections/feature.tsx
line 47 at r1 (raw file):
Previously, allada (Nathan (Blaise) Bruer) wrote…
changing this to an
a
will change the style, wont it?
The div ist styled with tailwind classes, i have tested the change to an link on the frontend, and it only put an underline to it.
So i force put the "no-underline!" class with ! and then its the same as the button before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 2 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 2 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
Type of change
Checklist
bazel test //...
passes locallygit amend
see some docsThis change is