Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken demo button link #1404

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

SchahinRohani
Copy link
Contributor

@SchahinRohani SchahinRohani commented Oct 10, 2024

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved


web/platform/src/components/qwik/sections/feature.tsx line 47 at r1 (raw file):

        ))}
      </div>
      <a

changing this to an a will change the style, wont it?

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved

Copy link
Contributor Author

@SchahinRohani SchahinRohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved


web/platform/src/components/qwik/sections/feature.tsx line 47 at r1 (raw file):

Previously, allada (Nathan (Blaise) Bruer) wrote…

changing this to an a will change the style, wont it?

The div ist styled with tailwind classes, i have tested the change to an link on the frontend, and it only put an underline to it.
So i force put the "no-underline!" class with ! and then its the same as the button before.

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 2 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved

Copy link
Contributor Author

@SchahinRohani SchahinRohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 2 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved

@SchahinRohani SchahinRohani merged commit f5de318 into TraceMachina:main Oct 15, 2024
35 checks passed
@SchahinRohani SchahinRohani deleted the fix/broken-links branch October 15, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants