Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dates on case studies. #1357

Merged

Conversation

MarcusSorealheis
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis commented Sep 25, 2024

Description

The publication date on one of our case studies was wrong.

Type of change

Please delete options that aren't relevant.

  • This change requires a documentation update

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Installation / macos-13, Remote / large-ubuntu-22.04, docker-compose-compiles-nativelink (22.04), and 2 discussions need to be resolved


-- commits line 2 at r1:

Suggestion:

Fix the date on Samsung case study

web/platform/src/content/posts/CaseStudy_Samsung.md line 6 at r1 (raw file):

image: https://static.wixstatic.com/media/48be99_30ae224dc45f453d80e48f7b9078d330~mv2.png/v1/fill/w_648,h_394,al_c,q_85,usm_0.66_1.00_0.01,enc_auto/x%20(3).png
slug: case-study-samsung
pubDate: 2024-08-13

nit: while we're at it, could you double-check the date of the ciq case study as well? That one also looks wrong.

Copy link
Contributor

@SchahinRohani SchahinRohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Remote / large-ubuntu-22.04, and 2 discussions need to be resolved

@SchahinRohani SchahinRohani enabled auto-merge (squash) September 25, 2024 01:34
@SchahinRohani
Copy link
Contributor

:lgtm:

@SchahinRohani SchahinRohani enabled auto-merge (squash) September 25, 2024 01:58
@MarcusSorealheis MarcusSorealheis enabled auto-merge (squash) September 25, 2024 02:23
@MarcusSorealheis MarcusSorealheis changed the title fix the date on Samsung Case Study. Fix the dates on case studies. Sep 25, 2024
Copy link
Collaborator Author

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 1 LGTMs obtained, and 1 of 2 files reviewed, and pending CI: windows-2022 / stable, and 2 discussions need to be resolved


-- commits line 2 at r1:
Done.

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Dismissed @aaronmondal from a discussion.
Reviewable status: :shipit: complete! 2 of 1 LGTMs obtained, and all files reviewed

@MarcusSorealheis MarcusSorealheis merged commit b770b13 into TraceMachina:main Sep 25, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants