SimpleScheduler version matching uses Aborted to know if failure #1308
Conversation
There was a problem hiding this comment.
(this PR is part of a chain, so only review r2-r3)
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 8 files reviewed, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache (Legacy Dockerfile Test), Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable (waiting on @adam-singer)
allada
force-pushed
the
simple-scheduler-abort-version-match
branch
from
771e98b to
7d78e70
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 6 of 6 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained, and all files reviewed
In the event of a failure of version matching for scheduler owning an operation we use Aborted error code to now signal that the version failed and can be retried. This is not a bug, current in-memory scheduler guarantees protections here, this is for lockless schedulers. towards TraceMachina#359
allada
force-pushed
the
simple-scheduler-abort-version-match
branch
from
7d78e70 to
f5129de
Compare
There was a problem hiding this comment.
Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status:
In the event of a failure of version matching for scheduler owning an
operation we use Aborted error code to now signal that the version
failed and can be retried.
This is not a bug, current in-memory scheduler guarantees protections
here, this is for lockless schedulers.
towards #359
This change is