Fix rare case where eof was sent on buf_channel when retry happens #1295
Conversation
allada
force-pushed
the
fix-buf-channel-eof-error
branch
from
1c88ead to
924569e
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 2 files reviewed, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache (Legacy Dockerfile Test), Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable (waiting on @adam-singer)
allada
force-pushed
the
fix-buf-channel-eof-error
branch
from
924569e to
264bb4b
Compare
allada
force-pushed
the
fix-buf-channel-eof-error
branch
from
264bb4b to
f90431f
Compare
In a rare case if an EOF is sent, then a retry is triggered by contract an EOF needs to be sent again, but without this patch we are not allowed to send and EOF after one is already sent.
allada
force-pushed
the
fix-buf-channel-eof-error
branch
from
f90431f to
c1690d1
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained, and all files reviewed
In a rare case if an EOF is sent, then a retry is triggered by contract an EOF needs to be sent again, but without this patch we are not allowed to send and EOF after one is already sent.
This change is