-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken variables in NativeLink Cloud CI jobs and disable RBE test #1293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, and 1 discussions need to be resolved
.github/workflows/main.yml
line 63 at r1 (raw file):
--remote_header=x-nativelink-project=nativelink-ci \ --remote_executor=grpcs://scheduler-tracemachina-shared.build-faster.nativelink.net:443 \ --remote_default_exec_properties="container-image=docker://$RBE_IMAGE" \
This is the most annoying github thing.. almost looks like a shell variable but isn't. ${RBE_IMAGE}
doesn't work on github actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi we need to fix the hash mismatch outlined in nlewo/nix2container#150 to unblock this.
Reviewed all commit messages.
Reviewable status: 2 of 1 LGTMs obtained, and all files reviewed, and pending CI: Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, and 1 discussions need to be resolved
Sent #1294 to fix the OCI workflow |
2dd5879
to
3e8dd5f
Compare
3e8dd5f
to
b69b7da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 2 of 1 LGTMs obtained, and all files reviewed
Description
Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.
Fixes # (issue)
Type of change
Please delete options that aren't relevant.
not work as expected)
How Has This Been Tested?
Please also list any relevant details for your test configuration
Checklist
bazel test //...
passes locallygit amend
see some docsThis change is