Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support remote build execution on main and read-only remote cache on PRs #1277

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

bclark8923
Copy link
Member

@bclark8923 bclark8923 commented Aug 23, 2024

Description

Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@bclark8923 bclark8923 force-pushed the read-only-pr-and-rbe-main branch from 8b95970 to 570fe02 Compare August 23, 2024 04:31
@bclark8923 bclark8923 force-pushed the read-only-pr-and-rbe-main branch from 570fe02 to 1d96a71 Compare August 23, 2024 04:32
@bclark8923 bclark8923 force-pushed the read-only-pr-and-rbe-main branch from 1d96a71 to b5d13cf Compare August 23, 2024 04:34
@bclark8923 bclark8923 force-pushed the read-only-pr-and-rbe-main branch from b5d13cf to d64aea0 Compare August 23, 2024 04:35
@bclark8923 bclark8923 force-pushed the read-only-pr-and-rbe-main branch from d64aea0 to c39a010 Compare August 23, 2024 16:16
@bclark8923 bclark8923 force-pushed the read-only-pr-and-rbe-main branch 2 times, most recently from fd09d3d to 0cec6c5 Compare August 23, 2024 16:17
@bclark8923 bclark8923 force-pushed the read-only-pr-and-rbe-main branch from 0cec6c5 to 032333a Compare August 23, 2024 16:56
Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: 2 of 1 LGTMs obtained, and all files reviewed, and pending CI: Cargo Dev / macos-13, Installation / macos-13, Installation / macos-14, Remote / large-ubuntu-22.04, nativelink-dot-com-cache-cloud-legacy-dockerfile-test

Copy link
Contributor

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: 2 of 1 LGTMs obtained, and all files reviewed, and pending CI: Remote / large-ubuntu-22.04

@bclark8923 bclark8923 force-pushed the read-only-pr-and-rbe-main branch from 118c71d to e725069 Compare August 29, 2024 18:44
@bclark8923 bclark8923 disabled auto-merge August 29, 2024 18:44
@bclark8923 bclark8923 enabled auto-merge (squash) August 29, 2024 19:01
Copy link
Member Author

@bclark8923 bclark8923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 LGTMs obtained, and all files reviewed

@bclark8923 bclark8923 merged commit 2f9fd8b into TraceMachina:main Aug 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants