Add WorkerStateManager for RedisStateManager #1022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
zbirenbaum
force-pushed
the
redis-worker-state
branch
3 times, most recently
from
67864cb to
f46b3d4
Compare
adam-singer
reviewed
Jun 19, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04)
zbirenbaum
force-pushed
the
redis-worker-state
branch
from
f46b3d4 to
88b9aaa
Compare
adam-singer
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Reviewed 4 of 7 files at r1, 3 of 3 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained
zbirenbaum
force-pushed
the
redis-worker-state
branch
5 times, most recently
from
74ed7d6 to
9b95726
Compare
Creates groundwork for Redis State Manager implementation by introducing two new structs. RedisOperation represents an operation stored in redis and RedisOperationState represents the wrapped object which implements the ActionStateResult trait.
Adds RedisStore based implementation for ClientStateManager trait. Provides API hooks for adding or filtering Operations.
Implements WorkerStateManager trait for RedisStateManager. Adds API hooks for worker-driven updates to OperationState.
zbirenbaum
force-pushed
the
redis-worker-state
branch
from
9b95726 to
499fc28
Compare
|
Changes merged in #1023 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements WorkerStateManager trait for RedisStateManager. Adds API hooks for worker-driven updates to operation state.
Requires: #1020 #1021
Type of change
Checklist
bazel test //...passes locallygit amendsee some docsThis change is