Skip to content

Commit

Permalink
Fix hardcoded value in local-image-test (#1545)
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronmondal authored Dec 15, 2024
1 parent c742302 commit f672af7
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions tools/public/local-image-test.nix
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,15 @@ writeShellScriptBin "local-image-test" ''
IMAGE_TAG=$(nix eval .#$1.imageTag --raw)
IMAGE_NAME=$(nix eval .#$1.imageName --raw)
nix run .#image.copyTo \
nix run .#$1.copyTo \
docker-daemon:''${IMAGE_NAME}:''${IMAGE_TAG}
# Ensure that the image has minimal closure size.
# TODO(aaronmondal): The default allows 10% inefficiency. Since we control all
# our images fully we should enforce 0% inefficiency. At
# the moment this breaks lre-cc.
CI=1 ${dive}/bin/dive \
''${IMAGE_NAME}:''${IMAGE_TAG} \
--highestWastedBytes=0
''${IMAGE_NAME}:''${IMAGE_TAG}
# TODO(aaronmondal): Keep monitoring this for better solutions to ratelimits:
# https://github.com/aquasecurity/trivy-action/issues/389
Expand Down

0 comments on commit f672af7

Please sign in to comment.