-
Notifications
You must be signed in to change notification settings - Fork 127
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove extraneous mod statements from tests (#975)
Integration tests are compiled into their own binaries, which are then executed. As such, there's no need to wrap integration tests in modules: ```rust // in `tests/some_test.rs` use some::dependency; #[cfg(test)] mod some_integration_test { use super::*; // Some tests go here. } ``` This is common practice in unit tests, which if not gated behind a `cfg` flag are included in the final release binary. We were mistakenly doing the same thing in integration tests, where it was unnecessary.
- Loading branch information
Showing
38 changed files
with
13,293 additions
and
13,689 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.