Minor update to OperationStateManager API

Makes convenience type for stream of action state results accessible from from the outside functions that will return it. Additionally changes filtering operations to be an async function so that blocking will not have to be used when getting the actions to filter is an async operation.
TraceMachina · Jun 3, 2024 · b8014e0 · b8014e0
1 parent da2c4a7
commit b8014e0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/nativelink-scheduler/src/operation_state_manager.rs b/nativelink-scheduler/src/operation_state_manager.rs
@@ -74,7 +74,7 @@ pub struct OperationFilter {
     pub unique_qualifier: Option<ActionInfoHashKey>,
 }
 
-type ActionStateResultStream = Pin<Box<dyn Stream<Item = Arc<dyn ActionStateResult>> + Send>>;
+pub type ActionStateResultStream = Pin<Box<dyn Stream<Item = Arc<dyn ActionStateResult>> + Send>>;
 
 #[async_trait]
 pub trait ClientStateManager {
@@ -108,7 +108,7 @@ pub trait WorkerStateManager {
 #[async_trait]
 pub trait MatchingEngineStateManager {
     /// Returns a stream of operations that match the filter.
-    fn filter_operations(&self, filter: OperationFilter) -> Result<ActionStateResultStream, Error>;
+    async fn filter_operations(&self, filter: OperationFilter) -> Result<ActionStateResultStream, Error>;
 
     /// Update that state of an operation.
     async fn update_operation(