Skip to content

Commit

Permalink
Revert "Allow nativelink flake module to upload results (#1369)"
Browse files Browse the repository at this point in the history
This partially reverts commit 9600839.

The original idea was to implement a `readonly` setting to dynamically
configure `--remote_upload_local_results`. While this is fairly
straightforward to implement it turned out that the UX implications
around the environment variables/scripts/files to configure this are
nontrivial and we need to evaluate the different approaches in more
depth first.

For now, revert to readonly by default and also add a small modifier to
the relevant workflow so that the write-access workflow retains the
ability to write artifacts on pushes to main.

Fixes #1371
  • Loading branch information
aaronmondal committed Sep 27, 2024
1 parent 68753c6 commit 2de7f00
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
--bes_backend=grpcs://bes-tracemachina-shared.build-faster.nativelink.net \
--bes_header=x-nativelink-api-key=$NL_COM_API_KEY \
--bes_results_url=https://app.nativelink.com/a/e3b1e0e0-4b73-45d6-85bc-5cb7b02edea5/build \
${{ github.ref == 'refs/heads/main' && ' ' || '--nogenerate_json_trace_profile --remote_upload_local_results=false' }} \
${{ github.ref == 'refs/heads/main' && '--remote_upload_local_results=true' || '--nogenerate_json_trace_profile --remote_upload_local_results=false' }} \
//..."
docker-compose-compiles-nativelink:
Expand Down
1 change: 1 addition & 0 deletions modules/nativelink.nix
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"--remote_instance_name=main"
"--remote_header=x-nativelink-project=nativelink-ci"
"--nogenerate_json_trace_profile"
"--remote_upload_local_results=false"
"--experimental_remote_cache_async"
];

Expand Down
2 changes: 2 additions & 0 deletions web/platform/src/content/docs/docs/nativelink-cloud/nix.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ build --remote_header=x-nativelink-api-key=065f02f53f26a12331d5cfd00a778fb243bfb
build --remote_instance_name=main
build --remote_header=x-nativelink-project=nativelink-ci
build --nogenerate_json_trace_profile
build --remote_upload_local_results=false
build --experimental_remote_cache_async
```
Expand All @@ -116,5 +117,6 @@ build:nativelink --remote_cache=grpcs://my-custom-endpoints.com
build:nativelink --remote_header=x-nativelink-api-key=my-custom-readonly-api-key
build:nativelink --remote_header=x-nativelink-project=nativelink-ci
build:nativelink --nogenerate_json_trace_profile
build:nativelink --remote_upload_local_results=false
build:nativelink --experimental_remote_cache_async
```

0 comments on commit 2de7f00

Please sign in to comment.