Skip to content

Commit

Permalink
Update Chromium Readme (#896)
Browse files Browse the repository at this point in the history
Co-authored-by: nadine hachouche <[email protected]>
  • Loading branch information
nfarah86 and nadine hachouche authored May 1, 2024
1 parent 7effcc4 commit 185eab3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion deployment-examples/chromium/03_build_chrome_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ else
cd ${HOME}
git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git
echo 'export PATH="${HOME}/depot_tools:$PATH"' >> ${HOME}/.bashrc
source ${HOME}/.bashrc
export PATH="${HOME}/depot_tools:$PATH"
fi

# Checkout chromium into home directory without history
Expand Down
10 changes: 7 additions & 3 deletions deployment-examples/chromium/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ This deployment sets up a 4-container deployment with separate CAS, scheduler
and worker. Don't use this example deployment in production. It's insecure.

> [!WARNING]
> - The client build request is best done from a Ubuntu image, `./03_build_chrome_tests.sh`
> - will check if the image is Ubuntu and fail otherwise
> - This tutorial has been tested in a Nix environment of version `2.21.0`
> - The client build request is best done from a Ubuntu image, `./03_build_chrome_tests.sh`. It will check if the image is Ubuntu and
> fail otherwise.
> - This tutorial has been tested in a Nix environment of version `2.
> 21.0`.
> - You need to install the [Docker](https://docs.docker.com/engine/install/ubuntu/) Engine in Ubuntu.
> - To get your Nix environment set up see the [official Nix installation documentation](https://nix.dev/install-nix).
All commands should be run from nix to ensure all dependencies exist in the environment.
Expand Down Expand Up @@ -85,3 +87,5 @@ When you're done testing, delete the cluster:
```bash
kind delete cluster
```
## NativeLink Community
If you have any questions, please reach out to the [NativeLink Community](https://join.slack.com/t/nativelink/shared_invite/zt-2i2mipfr5-lZAEeWYEy4Eru94b3IOcdg).

0 comments on commit 185eab3

Please sign in to comment.