-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding possibility for sputnik to load additional SpotBugs plugins like find-sec-bugs #229
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
============================================
- Coverage 72.38% 72.25% -0.14%
- Complexity 608 609 +1
============================================
Files 146 146
Lines 1988 2000 +12
Branches 131 133 +2
============================================
+ Hits 1439 1445 +6
- Misses 489 493 +4
- Partials 60 62 +2
Continue to review full report at Codecov.
|
6694cfb
to
4d9cc62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your support. I've added my thoughts on your implementation, please review them. 😎
src/main/java/pl/touk/sputnik/processor/spotbugs/SpotBugsProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/pl/touk/sputnik/processor/spotbugs/SpotBugsProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/pl/touk/sputnik/processor/spotbugs/SpotBugsProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/pl/touk/sputnik/processor/spotbugs/SpotBugsProcessor.java
Outdated
Show resolved
Hide resolved
src/test/java/pl/touk/sputnik/processor/spotbugs/SpotBugsProcessorTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've cleaned up code and I've implemented tests for my code.
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
============================================
- Coverage 74.98% 74.97% -0.02%
- Complexity 662 668 +6
============================================
Files 154 154
Lines 2099 2118 +19
Branches 136 138 +2
============================================
+ Hits 1574 1588 +14
- Misses 460 464 +4
- Partials 65 66 +1
Continue to review full report at Codecov.
|
Any news ? |
Any news ? This commit will add a lot to SpotBugs functionality inside the sputnik. For example, findsec-bugs are adding a lot of additional security rules that aren't currently possible to verify with basic SpotBugs. |
@SpOOnman could you review this change again ? 🙏 |
Bump |
1 similar comment
Bump |
up |
Up |
This commit is adding the functionality of loading SpotBugs all plugins placed in the path passed to configuration.