-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NU-1940] Add seconds to sample generator period editor and remove white arrows #7373
Merged
mslabek
merged 6 commits into
staging
from
nu-1940.add-seconds-to-sample-generator-period-editor
Jan 2, 2025
Merged
[NU-1940] Add seconds to sample generator period editor and remove white arrows #7373
mslabek
merged 6 commits into
staging
from
nu-1940.add-seconds-to-sample-generator-period-editor
Jan 2, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created: #7377 |
mslabek
force-pushed
the
nu-1940.add-seconds-to-sample-generator-period-editor
branch
from
December 31, 2024 12:43
72bdb75
to
ed405d9
Compare
arkadius
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please add changelog entry |
This reverts commit 0e96a76.
# Conflicts: # docs/Changelog.md
mslabek
force-pushed
the
nu-1940.add-seconds-to-sample-generator-period-editor
branch
from
January 2, 2025 14:55
3466945
to
1b0268c
Compare
mslabek
deleted the
nu-1940.add-seconds-to-sample-generator-period-editor
branch
January 2, 2025 16:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changelog entry for this PR is in #7376
2 changes:
Before
After
Checklist before merge