replaced spel parser #7370

JulianWielga · 2024-12-20T01:44:24Z

Summary by CodeRabbit

New Features
- Introduced a new parsing structure utilizing the ts-spel library for improved functionality.
- Added methods for parsing lists and objects in the AggMapLikeParser class.
Bug Fixes
- Updated expected outputs in test cases to reflect changes in parsing logic.
Tests
- Expanded test coverage with additional scenarios for parsing lists and maps, including complex object structures.

JulianWielga · 2024-12-20T01:46:32Z

coderabbitai · 2024-12-20T01:48:11Z

📝 Walkthrough

Walkthrough

This pull request introduces a significant refactoring of the parsing implementation in the Nussknacker Designer Client project. The changes primarily focus on replacing the chevrotain library with ts-spel for parsing map-like expressions in the AggMapLikeParser class.

The modification involves removing the chevrotain dependency from the package.json and adding the ts-spel library. In the aggMapLikeParser.tsx file, the parsing approach has been fundamentally changed from a token-based method to an Abstract Syntax Tree (AST) based parsing methodology.

The new implementation introduces private methods like #parse, #parseList, and #parseObject that leverage the ts-spel parser to handle various expression types. The class structure has been simplified, removing the previous inheritance from EmbeddedActionsParser and the complex token definitions.

The accompanying test file parser.test.ts has been updated to reflect these changes, adding new test cases that cover a broader range of parsing scenarios and updating expected outputs to match the new parsing approach.

Possibly related PRs

Aggregate map fix #7308: Changes to the package.json file involving chevrotain dependency updates

Suggested labels

refactoring, parser, dependency-update

Suggested reviewers

Dzuming

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90e00a9 and 83cf845.

⛔ Files ignored due to path filters (1)

designer/client/package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (3)

designer/client/package.json (1 hunks)
designer/client/src/components/graph/node-modal/aggregate/aggMapLikeParser.tsx (1 hunks)
designer/client/src/components/graph/node-modal/aggregate/parser.test.ts (4 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

JulianWielga · 2024-12-20T09:19:14Z

changes to ts-spel appended with patch are here https://github.com/JulianWielga/ts-spel/tree/nu-changes

designer/client/src/components/graph/node-modal/aggregate/parser.test.ts

arkadius · 2024-12-20T09:57:13Z

designer/client/src/components/graph/node-modal/aggregate/aggMapLikeParser.tsx

-        this.input = lexResult.tokens;
+    #parseObject(input: string, ast?: Ast) {
+        switch (ast?.type) {
+            case "InlineList":


Let's write a note that it is a work around for a bug in the ts-spel parser that it treats empty map as empty list (I'm not sure If I understand you correctly)

it's not a bug. it's the way it works. {} means empty list. i want to treat empty list as empty object in this case - that's all. there is no sense and case where ":" would be inserted. test case shows this clearly.

arkadius · 2024-12-20T09:59:03Z

designer/client/src/components/graph/node-modal/aggregate/aggMapLikeParser.tsx

-        const lexResult = this.lexer.tokenize(input);
-        this.fullText = input;
-        this.input = lexResult.tokens;
+    #parseObject(input: string, ast?: Ast) {


I would call it more precisely. It looks like it parse map aggregate aggregators, not a general object

it returns object - Record<string, string> and parses both: map and map wrapped with #AGG.map to the same format.

arkadius · 2024-12-20T10:00:25Z

designer/client/src/components/graph/node-modal/aggregate/aggMapLikeParser.tsx

-    parseList(input: string): Array<string> {
-        this.tokenizeInput(input);
-        return this.groupBy() || null;
+    #parseList(input: string, ast?: Ast) {


The same as above - I'd call it parseListToStringExpression or parseAggregateKey

replaced spel parser

83cf845

github-actions bot added client client main fe ui labels Dec 20, 2024

JulianWielga requested a review from mslabek December 20, 2024 09:01

arkadius reviewed Dec 20, 2024

View reviewed changes

refactor

5d5f320

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

replaced spel parser #7370

replaced spel parser #7370

JulianWielga commented Dec 20, 2024 •

edited by coderabbitai bot

Loading

JulianWielga commented Dec 20, 2024

coderabbitai bot commented Dec 20, 2024

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

JulianWielga commented Dec 20, 2024

arkadius Dec 20, 2024

JulianWielga Dec 20, 2024

arkadius Dec 20, 2024

JulianWielga Dec 20, 2024

arkadius Dec 20, 2024

replaced spel parser #7370

Are you sure you want to change the base?

replaced spel parser #7370

Conversation

JulianWielga commented Dec 20, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

JulianWielga commented Dec 20, 2024

coderabbitai bot commented Dec 20, 2024

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

JulianWielga commented Dec 20, 2024

arkadius Dec 20, 2024

Choose a reason for hiding this comment

JulianWielga Dec 20, 2024

Choose a reason for hiding this comment

arkadius Dec 20, 2024

Choose a reason for hiding this comment

JulianWielga Dec 20, 2024

Choose a reason for hiding this comment

arkadius Dec 20, 2024

Choose a reason for hiding this comment

JulianWielga commented Dec 20, 2024 •

edited by coderabbitai bot

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)