Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1923] Rename source 'periodic' to 'sample generator' #7368

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

mslabek
Copy link
Member

@mslabek mslabek commented Dec 19, 2024

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe docs ui labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

created: #7371
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

Copy link
Contributor

@lukasz-bigorajski lukasz-bigorajski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mslabek mslabek merged commit e863800 into staging Dec 20, 2024
18 checks passed
@mslabek mslabek deleted the nu-1923.rename-periodic-source branch December 20, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe docs ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants