Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1932] Big decimal uses default scale #7356

Merged
merged 20 commits into from
Dec 19, 2024
Merged

[NU-1932] Big decimal uses default scale #7356

merged 20 commits into from
Dec 19, 2024

Conversation

paw787878
Copy link
Contributor

@paw787878 paw787878 commented Dec 17, 2024 •
edited
Loading

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

updated: #7362
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

arkadius
arkadius reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog entry and fix tests

@github-actions github-actions bot added the docs label Dec 19, 2024
@paw787878 paw787878 enabled auto-merge (squash) December 19, 2024 12:58
@paw787878 paw787878 disabled auto-merge December 19, 2024 12:58
@paw787878 paw787878 merged commit 433ec63 into staging Dec 19, 2024
5 checks passed
@paw787878 paw787878 deleted the 1932-big-decimal-default-scale-fixes branch December 19, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lciolecki lciolecki lciolecki left review comments

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paw787878 @arkadius @lciolecki