-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce response payload size for scenarios tab #7354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elmacioro
force-pushed
the
reduce-response-for-services-tab
branch
from
December 17, 2024 15:48
7befc41
to
34b783b
Compare
Elmacioro
force-pushed
the
reduce-response-for-services-tab
branch
3 times, most recently
from
December 19, 2024 09:03
23934d7
to
40e2e7e
Compare
created: #7365 |
Elmacioro
force-pushed
the
reduce-response-for-services-tab
branch
from
December 20, 2024 07:22
40e2e7e
to
159a014
Compare
lciolecki
reviewed
Dec 23, 2024
...er/server/src/main/scala/pl/touk/nussknacker/ui/process/ScenarioWithDetailsConversions.scala
Show resolved
Hide resolved
Elmacioro
force-pushed
the
reduce-response-for-services-tab
branch
from
January 2, 2025 13:50
159a014
to
4e7a73a
Compare
Elmacioro
force-pushed
the
reduce-response-for-services-tab
branch
6 times, most recently
from
January 9, 2025 04:23
0920e39
to
98b18db
Compare
Dzuming
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE LGTM
lciolecki
reviewed
Jan 9, 2025
designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ProcessesResourcesSpec.scala
Outdated
Show resolved
Hide resolved
Elmacioro
force-pushed
the
reduce-response-for-services-tab
branch
from
January 9, 2025 19:03
2e8b4bf
to
9e45096
Compare
lciolecki
approved these changes
Jan 9, 2025
Elmacioro
added a commit
that referenced
this pull request
Jan 10, 2025
Elmacioro
added a commit
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Currently when we enter scenarios tab we fetch a lot of data regarding them. Some of the data isn't used at that level. It only bloats the response payload slowing down loading the tab.
In our Nussknacker instance we have a lot of scenarios so response payloads for that tab can reach around 7.6 MB. The biggest unused attribute that is sent along with the scenarios' details is
buildInfo
. We can remove it along with a few others not needed fields and we can also omit null attributes in the response JSON. By doing so we can decrease the response payload up to 25%. Which can help us a bit with long load times of scenarios tab.Checklist before merge