Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce response payload size for scenarios tab #7354

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

Elmacioro
Copy link
Contributor

@Elmacioro Elmacioro commented Dec 17, 2024

Describe your changes

Currently when we enter scenarios tab we fetch a lot of data regarding them. Some of the data isn't used at that level. It only bloats the response payload slowing down loading the tab.

In our Nussknacker instance we have a lot of scenarios so response payloads for that tab can reach around 7.6 MB. The biggest unused attribute that is sent along with the scenarios' details is buildInfo. We can remove it along with a few others not needed fields and we can also omit null attributes in the response JSON. By doing so we can decrease the response payload up to 25%. Which can help us a bit with long load times of scenarios tab.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Dec 17, 2024
@Elmacioro Elmacioro force-pushed the reduce-response-for-services-tab branch from 7befc41 to 34b783b Compare December 17, 2024 15:48
@Elmacioro Elmacioro marked this pull request as ready for review December 17, 2024 15:49
@Elmacioro Elmacioro force-pushed the reduce-response-for-services-tab branch 3 times, most recently from 23934d7 to 40e2e7e Compare December 19, 2024 09:03
Copy link
Contributor

created: #7365
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@Elmacioro Elmacioro force-pushed the reduce-response-for-services-tab branch from 40e2e7e to 159a014 Compare December 20, 2024 07:22
@Elmacioro Elmacioro force-pushed the reduce-response-for-services-tab branch from 159a014 to 4e7a73a Compare January 2, 2025 13:50
@github-actions github-actions bot added client client main fe ui labels Jan 3, 2025
@Elmacioro Elmacioro force-pushed the reduce-response-for-services-tab branch 6 times, most recently from 0920e39 to 98b18db Compare January 9, 2025 04:23
Copy link
Contributor

@Dzuming Dzuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE LGTM

@Elmacioro Elmacioro force-pushed the reduce-response-for-services-tab branch from 2e8b4bf to 9e45096 Compare January 9, 2025 19:03
@Elmacioro Elmacioro merged commit 15d99fc into staging Jan 9, 2025
18 checks passed
@Elmacioro Elmacioro deleted the reduce-response-for-services-tab branch January 9, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe docs ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants