Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch only latest scenario activities for periodic DM #7344

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Fetch only latest scenario activities for periodic DM #7344

merged 7 commits into from
Dec 17, 2024

Conversation

mgoworko
Copy link
Contributor

@mgoworko mgoworko commented Dec 16, 2024 •
edited
Loading

Describe your changes

Optionally limit the number of ScenarioActivities specific to Periodic DM, that are fetched from DM.

FE could not properly handle thousands of activities, their number needs to be, at least for now, limited.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Dec 16, 2024
@mgoworko mgoworko marked this pull request as ready for review December 16, 2024 15:30
@mgoworko mgoworko requested a review from piotrp December 17, 2024 09:40
piotrp
piotrp reviewed Dec 17, 2024
View reviewed changes
engine/flink/management/periodic/README.md Outdated
@@ -31,3 +31,4 @@ Use `deploymentManager` with the following properties:
- `deployMaxRetries` - maximum amount of retries for failed deployment.
- `deployRetryPenalize` - an amount of time by which the next retry should be delayed.
- `jarsDir` - directory for jars storage.
- `maxFetchedPeriodicScenarioActivities` - optional, maximum number of latest ScenarioActivities specific to DM, that will be fetched, by default unlimited
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unlimited -> 200

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specific to DM -> isn't this entire config structure specific to this DM?

@mgoworko mgoworko requested a review from piotrp December 17, 2024 10:06
@mgoworko mgoworko merged commit 2b7211f into staging Dec 17, 2024
9 of 10 checks passed
@mgoworko mgoworko deleted the fetch-only-latest-periodic-scenario-activities branch December 17, 2024 11:38
mgoworko added a commit that referenced this pull request Dec 17, 2024
@mgoworko
Fetch only latest scenario activities for periodic DM (#7344)
ae7bee7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrp piotrp piotrp approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgoworko @piotrp