Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer dictionary support in fragment inputs #7341

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

mateuszkp96
Copy link
Contributor

@mateuszkp96 mateuszkp96 commented Dec 16, 2024

Describe your changes

Added possibility to choose presets and define lists for Integer typed parameter inputs in fragments

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

Copy link
Contributor

github-actions bot commented Dec 17, 2024

created: #7359
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

Copy link
Contributor

@Elmacioro Elmacioro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mateuszkp96 mateuszkp96 force-pushed the integer-dictionary-support-in-fragment-inputs branch from 4c3014d to 788cf97 Compare December 18, 2024 12:14
@mateuszkp96 mateuszkp96 merged commit a8e0a79 into staging Dec 18, 2024
17 of 18 checks passed
@mateuszkp96 mateuszkp96 deleted the integer-dictionary-support-in-fragment-inputs branch December 18, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe docs ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants