Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1828] Processing types configs loader api #7336

Merged
merged 10 commits into from
Dec 17, 2024
Merged

[NU-1828] Processing types configs loader api #7336

merged 10 commits into from
Dec 17, 2024

Conversation

arkadius
Copy link
Member

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@arkadius arkadius changed the title Loadable processingTypes configs api Processing types configs loader api Dec 16, 2024
@arkadius arkadius requested a review from coutoPL December 16, 2024 18:30
@arkadius arkadius force-pushed the preview/loadable-configs-api branch from abd1cd4 to 443008f Compare December 17, 2024 10:36
coutoPL
coutoPL reviewed Dec 17, 2024
View reviewed changes
...onfig-loader-api/src/main/scala/pl/touk/nussknacker/ui/configloader/DesignerRootConfig.scala Outdated Show resolved Hide resolved
...der-api/src/main/scala/pl/touk/nussknacker/ui/configloader/ProcessingTypeConfigsLoader.scala Outdated Show resolved Hide resolved
.../src/main/scala/pl/touk/nussknacker/ui/configloader/ProcessingTypeConfigsLoaderFactory.scala Outdated Show resolved Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/api/description/DictApiEndpoints.scala Outdated Show resolved Hide resolved
...sknacker/ui/config/processingtype/EachTimeLoadingRootConfigProcessingTypeConfigsLoader.scala Outdated Show resolved Hide resolved
...er/ui/process/processingtype/loader/ProcessingTypesConfigBasedProcessingTypeDataLoader.scala Outdated Show resolved Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/server/AkkaHttpBasedRouteProvider.scala Outdated Show resolved Hide resolved
.../src/main/scala/pl/touk/nussknacker/ui/configloader/ProcessingTypeConfigsLoaderFactory.scala Outdated Show resolved Hide resolved
...sknacker/ui/config/processingtype/EachTimeLoadingRootConfigProcessingTypeConfigsLoader.scala Outdated Show resolved Hide resolved
...k/nussknacker/ui/config/processingtype/ProcessingTypeConfigsLoaderFactoryServiceLoader.scala Outdated Show resolved Hide resolved
@coutoPL

This comment was marked as resolved.

Sign in to view
@arkadius arkadius changed the title Processing types configs loader api [NU-1828] Processing types configs loader api Dec 17, 2024
@arkadius arkadius requested a review from coutoPL December 17, 2024 20:03
coutoPL
coutoPL approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments left.
In general - LGTM

@arkadius arkadius merged commit a5d5305 into staging Dec 17, 2024
29 checks passed
@arkadius arkadius deleted the preview/loadable-configs-api branch December 17, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coutoPL coutoPL coutoPL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arkadius @coutoPL