Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1772] ScenarioActivity-based activity log #7039

Merged
merged 13 commits into from
Oct 24, 2024
Merged

[NU-1772] ScenarioActivity-based activity log #7039

merged 13 commits into from
Oct 24, 2024

Conversation

mgoworko
Copy link
Contributor

@mgoworko mgoworko commented Oct 17, 2024 •
edited
Loading

Describe your changes

Added logging based on ScenarioActivity handling:

  • simple logger.info, corresponding to operations performed on SenarioActivity'ies

Format of log is open for discussion, it is more of a POC and something that works, not it must be adjusted.

full scenario audit log from tests.log

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@mgoworko mgoworko marked this pull request as ready for review October 17, 2024 15:03
coutoPL
coutoPL requested changes Oct 21, 2024
View reviewed changes
designer/server/src/main/scala/pl/touk/nussknacker/ui/process/ProcessService.scala Show resolved Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/process/ScenarioActivityAuditLog.scala Outdated Show resolved Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/process/ScenarioActivityAuditLog.scala Outdated Show resolved Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/process/ScenarioActivityAuditLog.scala Outdated Show resolved Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/process/ScenarioActivityAuditLog.scala Outdated Show resolved Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/process/ScenarioActivityAuditLog.scala Outdated Show resolved Hide resolved
...rver/src/main/scala/pl/touk/nussknacker/ui/process/repository/ScenarioActionRepository.scala Outdated Show resolved Hide resolved
...la/pl/touk/nussknacker/ui/process/repository/ScenarioActionRepositoryAuditLogDecorator.scala Show resolved Hide resolved
...la/pl/touk/nussknacker/ui/process/repository/ScenarioActionRepositoryAuditLogDecorator.scala Outdated Show resolved Hide resolved
...ssknacker/ui/process/repository/activities/ScenarioActivityRepositoryAuditLogDecorator.scala Show resolved Hide resolved
@github-actions github-actions bot added the docs label Oct 22, 2024
@mgoworko mgoworko requested a review from coutoPL October 22, 2024 12:16
coutoPL
coutoPL approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

created: #7075
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@mgoworko
Merge remote-tracking branch 'origin/staging' into NU-1772-activity-log
4850dd4
@mgoworko
Merge remote-tracking branch 'origin/staging' into NU-1772-activity-log
6156746 
# Conflicts:
#	designer/server/src/main/scala/pl/touk/nussknacker/ui/process/repository/activities/DbScenarioActivityRepository.scala
#	designer/server/src/main/scala/pl/touk/nussknacker/ui/process/repository/activities/ScenarioActivityRepository.scala
@mgoworko
after merge adjustments
a4e30d3
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Closed
@mgoworko mgoworko merged commit a4d84cc into staging Oct 24, 2024
18 checks passed
@mgoworko mgoworko deleted the NU-1772-activity-log branch October 24, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coutoPL coutoPL coutoPL approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgoworko @coutoPL