-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka exceptionHandler: retry when message is too large, log when writing to Kafka fails #6958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrp
force-pushed
the
kafka-errors-retry
branch
from
September 26, 2024 21:10
ffff202
to
31b999c
Compare
created: #6961 |
piotrp
force-pushed
the
kafka-errors-retry
branch
2 times, most recently
from
September 26, 2024 22:28
72a7b1a
to
a7dfedd
Compare
piotrp
force-pushed
the
kafka-errors-retry
branch
from
September 27, 2024 11:36
f3adb3e
to
83e1418
Compare
piotrp
force-pushed
the
kafka-errors-retry
branch
from
October 6, 2024 20:40
565df12
to
28b7e73
Compare
arkadius
reviewed
Oct 7, 2024
...scala/pl/touk/nussknacker/engine/kafka/exception/KafkaJsonExceptionSerializationSchema.scala
Show resolved
Hide resolved
...scala/pl/touk/nussknacker/engine/kafka/exception/KafkaJsonExceptionSerializationSchema.scala
Show resolved
Hide resolved
...scala/pl/touk/nussknacker/engine/kafka/exception/KafkaJsonExceptionSerializationSchema.scala
Show resolved
Hide resolved
I pushed a change that makes variable removal function public - I need it in a custom exception serializer |
arkadius
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Log errors that are thrown from Kafka producer. Try to somehow handle situations where we try to write exception info that is too large to log.
Checklist before merge