Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka exceptionHandler: retry when message is too large, log when writing to Kafka fails #6958

Merged
merged 9 commits into from
Oct 10, 2024

Conversation

piotrp
Copy link
Member

@piotrp piotrp commented Sep 26, 2024

Describe your changes

Log errors that are thrown from Kafka producer. Try to somehow handle situations where we try to write exception info that is too large to log.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

Copy link
Contributor

github-actions bot commented Sep 26, 2024

created: #6961
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@piotrp piotrp force-pushed the kafka-errors-retry branch from 565df12 to 28b7e73 Compare October 6, 2024 20:40
@piotrp
Copy link
Member Author

piotrp commented Oct 9, 2024

I pushed a change that makes variable removal function public - I need it in a custom exception serializer

@piotrp piotrp merged commit 2224d33 into staging Oct 10, 2024
18 checks passed
@piotrp piotrp deleted the kafka-errors-retry branch October 10, 2024 20:11
piotrp added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants