Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1768] Auto convert SQL enricher returning types #6586

Merged
merged 10 commits into from
Aug 26, 2024
Merged

[NU-1768] Auto convert SQL enricher returning types #6586

merged 10 commits into from
Aug 26, 2024

Conversation

lukasz-bigorajski
Copy link
Contributor

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1768.fix.sql.enricher.returning.types branch from 9ec8f60 to 73eea91 Compare August 13, 2024 06:15
@github-actions github-actions bot added the docs label Aug 13, 2024
@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1768.fix.sql.enricher.returning.types branch 2 times, most recently from ae334ed to 7b7304d Compare August 19, 2024 08:39
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

created: #6601
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1768.fix.sql.enricher.returning.types branch 2 times, most recently from 58ab6f9 to a756bda Compare August 19, 2024 09:23
@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1768.fix.sql.enricher.returning.types branch from a756bda to 81add5e Compare August 26, 2024 16:26
mk-software-pl
mk-software-pl approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@mk-software-pl mk-software-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasz-bigorajski lukasz-bigorajski merged commit f842639 into staging Aug 26, 2024
18 checks passed
@lukasz-bigorajski lukasz-bigorajski deleted the nu.1768.fix.sql.enricher.returning.types branch August 26, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mk-software-pl mk-software-pl mk-software-pl approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasz-bigorajski @mk-software-pl