Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added docsUrl to PropertiesConfig #6578

Merged
merged 32 commits into from
Sep 3, 2024
Merged

Added docsUrl to PropertiesConfig #6578

merged 32 commits into from
Sep 3, 2024

Conversation

Diamekod0221
Copy link
Contributor

@Diamekod0221 Diamekod0221 commented Aug 9, 2024 •
edited
Loading

Describe your changes

We want to make it possible to display a docsUrl with icon in scenario properties, based on processing type and configurable by model.conf

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot mentioned this pull request Aug 9, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024 •
edited
Loading

created: #6724
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@Diamekod0221 Diamekod0221 marked this pull request as ready for review August 17, 2024 15:42
@github-actions github-actions bot added client client main fe ui labels Aug 17, 2024
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Closed
@github-actions github-actions bot added the docs label Aug 23, 2024
Dzuming
Dzuming approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@Dzuming Dzuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend LGTM

@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Closed
Marcel Philipiak and others added 23 commits September 3, 2024 20:55
renaming fixes
53dbd04
changed ScenarioProperties structure on FE
6604004
Remove ++ method
8ac81bc
removed test.txt
f542fc1
fixes
4e2d4ce 
remove ++

baseflowtest fixes
added url display logic
792797b
fix processingtypedata
2dfdee9
renaming for PR
9184870
subheader fix
6b84d1b
remodeled config load
843aff3
test fixes after config change
0ad6110
docs update
35eb9ad
model conf changes
13ef4ed
remove console log
b63f16d
revert config naming to scenarioPropertiesConfig
20d1f47
changed docs wording for PR
1a41902
renames PR
9fdb8ed
@gskrobisz
Revert class rename, rename moved to #6711
c662721
@gskrobisz
remove empty file
bb61793
@gskrobisz
Move docsUrl from ProcessingTypeData (and DeploymentData and Deployme…
3dd28f9 
…ntManagerProvider) to DefinitionsService where UI config is being built.
@gskrobisz
PR upd
ed01cd5
@gskrobisz
split fragment and scenario docsurl
6400007
Frontend fix
b9714ae
@Diamekod0221 Diamekod0221 merged commit 42e60a0 into staging Sep 3, 2024
16 of 18 checks passed
@Diamekod0221 Diamekod0221 deleted the Add_properties_url branch September 3, 2024 20:08
Diamekod0221 added a commit that referenced this pull request Sep 3, 2024
@Diamekod0221 @gskrobisz
Added docsUrl to PropertiesConfig (#6578)
ab1b5cb 
* Added docsUrl to PropertiesConfig on BE, added docsUrl icon display in properties on FE

Co-authored-by: Marcel Philipiak <[email protected]>
Co-authored-by: gskrobisz <[email protected]>
Diamekod0221 added a commit that referenced this pull request Sep 3, 2024
@Diamekod0221 @gskrobisz
Added docsUrl to PropertiesConfig (#6578)
cc62621 
* Added docsUrl to PropertiesConfig on BE, added docsUrl icon display in properties on FE


Co-authored-by: Marcel Philipiak <[email protected]>
Co-authored-by: gskrobisz <[email protected]>
raphaelsolarski pushed a commit that referenced this pull request Sep 6, 2024
@Diamekod0221 @gskrobisz @raphaelsolarski
Added docsUrl to PropertiesConfig (#6578)
f67ee66 
* Added docsUrl to PropertiesConfig on BE, added docsUrl icon display in properties on FE


Co-authored-by: Marcel Philipiak <[email protected]>
Co-authored-by: gskrobisz <[email protected]>
raphaelsolarski pushed a commit that referenced this pull request Sep 6, 2024
@Diamekod0221 @gskrobisz
Added docsUrl to PropertiesConfig (#6578) (#6744)
a142c76 
* Added docsUrl to PropertiesConfig on BE, added docsUrl icon display in properties on FE

Co-authored-by: Marcel Philipiak <[email protected]>
Co-authored-by: gskrobisz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gskrobisz gskrobisz gskrobisz left review comments

@arkadius arkadius arkadius left review comments

@Dzuming Dzuming Dzuming approved these changes

Assignees
No one assigned
Labels
client client main fe docs ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Diamekod0221 @arkadius @gskrobisz @Dzuming