Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1557] Test on generated data for Table Source #6340

Merged
merged 9 commits into from
Jul 29, 2024
Merged

[NU-1557] Test on generated data for Table Source #6340

merged 9 commits into from
Jul 29, 2024

Conversation

mslabek
Copy link
Member

@mslabek mslabek commented Jul 8, 2024

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

created: #6494
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@mslabek mslabek changed the title Test on dumped data table source [NU-1557] Test on dumped data table source Jul 9, 2024
@mslabek mslabek force-pushed the test-on-dumped-data-table-source branch from fa6d8df to 8241886 Compare July 9, 2024 13:00
@github-actions github-actions bot mentioned this pull request Jul 10, 2024
Closed
@mslabek mslabek force-pushed the test-on-dumped-data-table-source branch from cde6ba0 to e86d596 Compare July 18, 2024 13:19
@github-actions github-actions bot added the docs label Jul 18, 2024
@mslabek mslabek changed the title [NU-1557] Test on dumped data table source [NU-1557] Test on generated data for Table Source Jul 18, 2024
@github-actions github-actions bot mentioned this pull request Jul 19, 2024
Closed
@mslabek mslabek marked this pull request as ready for review July 19, 2024 12:59
@mslabek mslabek force-pushed the test-on-dumped-data-table-source branch from 65a0df3 to 8d94056 Compare July 19, 2024 13:23
@mslabek mslabek requested a review from raphaelsolarski July 22, 2024 09:37
raphaelsolarski
raphaelsolarski approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@raphaelsolarski raphaelsolarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/testmode/TestDataPreparer.scala Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Closed
@mslabek mslabek merged commit 86cd553 into staging Jul 29, 2024
17 of 18 checks passed
@mslabek mslabek deleted the test-on-dumped-data-table-source branch July 29, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelsolarski raphaelsolarski raphaelsolarski approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mslabek @raphaelsolarski