Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1679] table join component #6320

Merged
merged 3 commits into from
Jul 24, 2024
Merged

[NU-1679] table join component #6320

merged 3 commits into from
Jul 24, 2024

Conversation

arkadius
Copy link
Member

@arkadius arkadius commented Jul 4, 2024

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@arkadius arkadius force-pushed the table-join branch 2 times, most recently from c44f977 to 4b1aad8 Compare July 12, 2024 15:08
@github-actions github-actions bot added the docs label Jul 12, 2024
@arkadius arkadius marked this pull request as ready for review July 12, 2024 16:50
@arkadius arkadius changed the base branch from staging to stream-of-rows-poc July 12, 2024 16:50
@arkadius arkadius changed the base branch from stream-of-rows-poc to staging July 12, 2024 17:06
@arkadius arkadius changed the base branch from staging to stream-of-rows-poc July 12, 2024 17:08
Base automatically changed from stream-of-rows-poc to staging July 23, 2024 12:55
@lukasz-bigorajski lukasz-bigorajski self-requested a review July 23, 2024 13:12
lukasz-bigorajski
lukasz-bigorajski approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@lukasz-bigorajski lukasz-bigorajski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot mentioned this pull request Jul 23, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

created: #6444
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@arkadius arkadius requested a review from raphaelsolarski July 24, 2024 09:23
@arkadius arkadius merged commit 5b13301 into staging Jul 24, 2024
12 of 18 checks passed
@arkadius arkadius deleted the table-join branch July 24, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasz-bigorajski lukasz-bigorajski lukasz-bigorajski approved these changes

@raphaelsolarski raphaelsolarski raphaelsolarski approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkadius @raphaelsolarski @lukasz-bigorajski