Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypingResult.valueOpt for the purpose of SpEL validator #6269

Merged
merged 9 commits into from
Jul 17, 2024

Conversation

wrzontek
Copy link
Contributor

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@wrzontek
Copy link
Contributor Author

It just came to me that this could be the case for other classes being incompatible between java and scala for the purpose of SpEL validation, I'll check them tomorrow.

@wrzontek wrzontek closed this Jun 26, 2024
@wrzontek
Copy link
Contributor Author

this needs to be addressed more throughly now that i've slept on it

@wrzontek wrzontek reopened this Jun 27, 2024
@wrzontek wrzontek marked this pull request as draft June 27, 2024 13:38
@wrzontek wrzontek changed the title Convert Scala Map[_, _] to Java before using ValidationExpressionParameterValidator Fix TypingResult.valueOpt for the purpose of SpEL validator Jun 27, 2024
@wrzontek wrzontek marked this pull request as ready for review July 2, 2024 12:18
@wrzontek wrzontek requested a review from arkadius July 3, 2024 08:40
@wrzontek
Copy link
Contributor Author

wrzontek commented Jul 9, 2024

CI passes except for known flaky k8 test failures

Lists are typed as TypedObjectWithValue
@wrzontek wrzontek force-pushed the fix-scala-map-in-spel-validator branch from c2daaa3 to 449eef0 Compare July 10, 2024 14:42
@wrzontek wrzontek requested review from arkadius and mslabek July 10, 2024 15:06
@wrzontek
Copy link
Contributor Author

wrzontek commented Jul 11, 2024

Limitation: as with selection/projection, some #COLLECTION helper methods also mostly lose value (not a regression, value is lost in cases where before it wasn't even kept)

Keeping value could probably be implemented for all of them, with varying degrees of difficulty/jank (easy example: concat, merge, complicated example: product, shuffle etc.)

@github-actions github-actions bot added the docs label Jul 17, 2024
@wrzontek
Copy link
Contributor Author

merging after re-approve from @mslabek

@wrzontek wrzontek merged commit e7e0504 into staging Jul 17, 2024
16 of 18 checks passed
@wrzontek wrzontek deleted the fix-scala-map-in-spel-validator branch July 17, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants