-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TypingResult.valueOpt
for the purpose of SpEL validator
#6269
Conversation
It just came to me that this could be the case for other classes being incompatible between java and scala for the purpose of SpEL validation, I'll check them tomorrow. |
this needs to be addressed more throughly now that i've slept on it |
TypingResult.valueOpt
for the purpose of SpEL validator
designer/server/src/test/scala/pl/touk/nussknacker/ui/validation/UIProcessValidatorSpec.scala
Outdated
Show resolved
Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/validation/UIProcessValidatorSpec.scala
Outdated
Show resolved
Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/validation/UIProcessValidatorSpec.scala
Outdated
Show resolved
Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/validation/UIProcessValidatorSpec.scala
Outdated
Show resolved
Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/spel/Typer.scala
Outdated
Show resolved
Hide resolved
CI passes except for known flaky k8 test failures |
components-api/src/main/scala/pl/touk/nussknacker/engine/api/typed/typing.scala
Outdated
Show resolved
Hide resolved
Lists are typed as TypedObjectWithValue
c2daaa3
to
449eef0
Compare
Limitation: as with selection/projection, some #COLLECTION helper methods also mostly lose value (not a regression, value is lost in cases where before it wasn't even kept) Keeping value could probably be implemented for all of them, with varying degrees of difficulty/jank (easy example: concat, merge, complicated example: product, shuffle etc.) |
merging after re-approve from @mslabek |
(cherry picked from commit e7e0504)
(cherry picked from commit e7e0504)
Describe your changes
Checklist before merge