-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NU-1719] Component statistics without restmodel #6258
Conversation
3c50979
to
b7ee445
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About counting components stats I will write later
designer/server/src/main/scala/pl/touk/nussknacker/ui/statistics/ScenarioStatistics.scala
Outdated
Show resolved
Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/statistics/ScenarioStatistics.scala
Outdated
Show resolved
Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/statistics/ScenarioStatistics.scala
Outdated
Show resolved
Hide resolved
designer/server/src/main/scala/pl/touk/nussknacker/ui/statistics/ScenarioStatistics.scala
Outdated
Show resolved
Hide resolved
Having 2 logics for counting usages can be misleading and error prone so we should use logic that we have currently. I am looking at componentsService now and I wonder if it will be enough to add method:
and then:
but I have to confirm how is matched |
2fbf4d7
to
5cfc2a3
Compare
created: #6318 |
5cfc2a3
to
70662d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Have you manually tested this components usage count on local nu?
…d to rewrite some tests due to the change
And extracted some values as consts
… nussknacker package
…one key so they overridden each other instead of being added
…erly If componentId not found - it's connected to fragments, so we don't send that data
7167f10
to
adfd72a
Compare
* Statistics for components look the same as while using restmodel, need to rewrite some tests due to the change * In component usage statistic not all custom components were labeled as such * Component usage is calculated by using one of componentService methods And extracted some values as consts * Replaced checking head with the whole list of components if it's from nussknacker package * Added example dummy custom component to check if mechanism works properly If componentId not found - it's connected to fragments, so we don't send that data * Fix for 2.12 it couldn't compile 'removed' for map --------- Co-authored-by: Szymon Bogusz <[email protected]>
Describe your changes
Remove creating
ComponentListElement
DTOs just to get component usages.Instead, map of usages per
DesignerWideComponentId
is provided byComponentService
and then mapped by id to available componentsChecklist before merge