Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Preview/mpk va 1.9.1 #107

Closed
wants to merge 19 commits into from
Closed

Draft: Preview/mpk va 1.9.1 #107

wants to merge 19 commits into from

Conversation

pielas
Copy link
Contributor

@pielas pielas commented Aug 16, 2023

No description provided.

@pielas pielas changed the title Preview/mpk va 1.9.1 Draft: Preview/mpk va 1.9.1 Aug 29, 2023
@@ -88,6 +97,13 @@ data:
"schema.registry.url": "{{ include "nussknacker.schemaRegistryUrl" . }}"
}
}
{{- else if and (eq .Values.nussknacker.mode "ververica") (not .Values.nussknacker.skipKafkaConfig ) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add or in line 83 instead of duplicating this

@@ -185,6 +185,8 @@ nussknacker-request-response-scenario
{{- define "nussknacker.modelClassPath" -}}
{{- if .Values.nussknacker.modelClassPath -}}
{{ tpl ( mustToJson .Values.nussknacker.modelClassPath) . }}
{{- else if eq .Values.nussknacker.mode "ververica" -}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add or 2 lines below instead of duplicating it

@@ -7,6 +7,7 @@ on:
push:
branches:
- main
- 'preview/*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's extract these changes to separate MR and merge it now

@pielas pielas closed this Oct 18, 2023
@pielas pielas deleted the preview/mpk-va-1.9.1 branch October 18, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants