Add support for type aliases #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, the code looks really well! |
|
Sure, I'll add that this evening! |
|
I'm running into a few issues (I think with Exposed itself, it may not support |
This required slight modification to the code generation in order to properly use the underlying type of an alias in certain locations and the name of the typealias in others. Additionally, had to remove support for unwrapping iterables from the string wrapper class but there aren't many use cases for that feature that I can think of.
|
@pjagielski Finally got it figured out. Just had to override a default implementation that was auto unrolling |
|
@pjagielski ping :) |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, adds support for type aliases.
This should help resolve issue #9 because it becomes possible to do
and have a converter to convert from say
StringMapto String which krush seems to find acceptable. Then just replace any instances ofMap<String, String>withStringMapand it's off to the races.This request was written out of a need to resolve issue #9 for a personal project, so it was either this or implement type properties correctly. Please let me know if I am missing any conventions! I didn't write any examples but could probably get some going in short order. Thanks!