Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test redis adapter #439

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Test redis adapter #439

merged 9 commits into from
Jan 16, 2025

Conversation

Totodore
Copy link
Owner

@Totodore Totodore commented Jan 16, 2025

  • Improve the adapter test-suite to cover a lot more cases.
  • Fix issues on redis adapter:
    • The ack stream was closed if the remote part was closed without checking the local one.
    • The expected response count when waiting for responses was set to server count even when sending the request to a single server leading to waiting for the timeout before getting the response.
  • Fix issue on RemoteSocket struct, the impl RoomParam lifetime was bound to the async function for leave and join fns. Therefore it was impossible to use &'static str whereas RoomParam is implemented for &'static str.
  • Manual implementation for some Clone and Debug to avoid automatic bound on generic adapter.

@Totodore Totodore added C-Bug Something isn't working A-socketioxide Area related to socketioxide A-redis-adapter Area related to redis-adapter T-testing Topic: testing labels Jan 16, 2025
@Totodore Totodore merged commit 39ab18a into main Jan 16, 2025
30 checks passed
@Totodore Totodore deleted the test-redis-adapter branch January 16, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-redis-adapter Area related to redis-adapter A-socketioxide Area related to socketioxide C-Bug Something isn't working T-testing Topic: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant