feat: improve Adapter error types for broadcast and disconnect methods
#408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove Sync bound on adapter error * Add an AdapterCtr trait to keep state
This will allow adapter implementors to use the `LocalAdapter` as a parent.
This will allow to share errors between nodes. The parser error is also now a Boxed error in order to have multiple dyn possible implementations;
Change the error type for `broadcast_with_ack` and `disconnect`. Now it is a `BroadcastError` that handle all error cases.
Totodore
force-pushed
the
async-adapter
branch
from
063c50d to
e2ee822
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Totodore
force-pushed
the
async-adapter
branch
from
28a2f95 to
f97c108
Compare
Totodore
force-pushed
the
async-adapter
branch
from
f97c108 to
d27a07f
Compare
Totodore
added a commit
that referenced
this pull request
Jan 12, 2025
* feat(socketio): async adapter (#395) * feat: improve `Adapter` error types for `broadcast` and `disconnect` methods (#408) * feat(socketio/ns): improve `SocketEmitter` trait (#410) * feat(core/adapter): pass filter to get_sids * feat: add custom `Iterator` return for apply_opts fn * chore(docs): add doc on async adapters (#411) * feat(adapter): add a remote socket API (#412) * feat(core): switch to a new type for server uid (#413) * chore(deps): rm `__test_harness` && `tracing` feature flags. * chore(deps): add fuzzing as cfg flag * chore(ci): msrv * chore(clippy): fix redundant import (#414) * feat(core): improve local adapter perf (#415) * test(e2e): provide e2e testing system for adapters (#422) * test(e2e): provide e2e testing system for adapters * fix(e2e/adapter): remove redis deps * feat(socketio): check namespaces at insertion * feat(redis): redis adapter crate (#402)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
broadcastanddisconnectmethods now aResult<_, BroadcastError>. Therefore the error can handle all cases (parser issue, internal socket channel full or adapter error).Remove also the packet types re-export from socketioxide.