Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engineio/packet): array expand for packet event only when not empty #134

Merged
merged 4 commits into from
Nov 4, 2023

Conversation

Totodore
Copy link
Owner

@Totodore Totodore commented Nov 4, 2023

When encoding packet, array should be expanded only when it is not empty. If the array is empty it should be specified like this : ["event", []] and not ["event"]

socketioxide/src/packet.rs Fixed Show fixed Hide fixed
@Totodore Totodore changed the title fix(engineio/packet): array expand for packet event fix(engineio/packet): array expand for packet event only when not empty Nov 4, 2023
@Totodore Totodore merged commit 8983824 into main Nov 4, 2023
@Totodore Totodore deleted the fix-packet-array-expand branch November 4, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant