fix: apply max payload option when encoding (fix #113) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR apply the
max_payload_sizeoption to the encoding process for polling. Before, it was only applied when decoding.In order to calculate the size of the payload with the next packet without polling it from the channel, a
PeekableReceiverstruct was made topeekthe next element without polling it.For the v3 protocol the current payload computed size is not accurate because the size in
charsof the packet is included in the payload. And getting that information before adding the packet is not possible (also it is a O(n) operation). Therefore the max packet size length is apply, it is the number of digit of the maximum payload size.