Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset lurker status when a lurker's level is played or the queue is cleared #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

demize
Copy link

@demize demize commented Aug 17, 2022

Had an issue with one of my viewers who consistently showed as offline despite clearly being online; we managed to figure out that it was because he !brb'd at some point and never did !back. If you're running the bot only during streams this is fine, but when you run the bot persistently it never gets a chance to reset the lurkers.

This PR resets the list of lurkers on clear, as well as when a level is manually selected, to prevent such cases.

@liquidnya
Copy link

I wonder if twitch.notLurkingAnymore(username); should be called for other commands as well.

For example !level, !next, !subrandom, etc.
Because the queue picks from offline people whenever there are no online people in the queue.

@demize
Copy link
Author

demize commented Aug 17, 2022

I wonder if twitch.notLurkingAnymore(username); should be called for other commands as well.

For example !level, !next, !subrandom, etc. Because the queue picks from offline people whenever there are no online people in the queue.

Ah, good point. Was an easy enough thing to implement; it looks like for every level that's pulled up, it either uses next_level_message or weighted_level_message and that's a convenient place to do the unlurking. It's now added to this PR :)

@demize demize changed the title Reset lurker status on select/clear Reset lurker status when a lurker's level is played or the queue is cleared Aug 17, 2022
- When they leave the queue
- When their level is pulled up through !select
- When their level is pulled up when only offline users are left in the queue
@demize
Copy link
Author

demize commented Aug 17, 2022

And one more update... also unlurks on !leave. Squashed and force pushed myself to reduce the number of commits that end up on the main branch (and limit how many emails I get about new commits when this ends up merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants