Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve settings tests and validation #27

Merged
merged 5 commits into from
Oct 25, 2022
Merged

Improve settings tests and validation #27

merged 5 commits into from
Oct 25, 2022

Conversation

liquidnya
Copy link

@liquidnya liquidnya commented Jun 16, 2022

  • Change test cases to use settings.js instead of a mock of settings.js by writing the settings to settings.json inside the virtual file system before starting the queue. (already done by Add new save file handling #22)
  • Add a validation for channel: This needs to be a valid twitch username consisting of only lowercase letters, numbers, and underlines and have at least 3 letters. This is validated, because the channel is used in the URL in twitch.js and setting something else (e.g. your display name with uppercase letters, or e.g. containing kanji) will not work and the bot will crash at a later time anyways.
  • Make it more clear that the lowercase username is needed in the example settings file and remove gender from example. (already done by Add new save file handling #22)

@ToransuShoujo ToransuShoujo merged commit 59eec17 into ToransuShoujo:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants