Improve settings tests and validation #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change test cases to use(already done by Add new save file handling #22)settings.js
instead of a mock ofsettings.js
by writing the settings tosettings.json
inside the virtual file system before starting the queue.channel
: This needs to be a valid twitch username consisting of only lowercase letters, numbers, and underlines and have at least 3 letters. This is validated, because thechannel
is used in the URL intwitch.js
and setting something else (e.g. your display name with uppercase letters, or e.g. containing kanji) will not work and the bot will crash at a later time anyways.Make it more clear that the lowercase username is needed in the example settings file and remove gender from example.(already done by Add new save file handling #22)