[proxy-agent] Allow asynchronous getProxyForUrl
#275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to use an asynchronous getProxyForUrl in case they need to do asynchronous operations to resolve the correct proxy URL. This can be the case, for example, if using Electron.Session.resolveProxy(url).
🦋 Changeset detectedLatest commit: 22b5af9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TooTallNate
reviewed
Feb 12, 2024
TooTallNate
reviewed
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to use an asynchronous
getProxyForUrlin case they need to do asynchronous operations to resolve the correct proxy URL. This can be the case, for example, if usingElectron.Session.resolveProxy(url).Fixes #264
Test suites seem to pass; added a new one to exercise this functionality, but I can delete it if that seems like overkill.
I opted for a patch level release, because this should not affect any existing users.