Make decoding of base64 data URIs faster #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw in microsoft/vscode-js-debug#1911 that base64 decoding of a data URI was taking a bit of time. This PR feature-detects the presence of a global `Buffer` to use native decoding when running in Node.js, which is about 25x faster on a 10MB data URI than the JS implementation in the library. I have a bit of a hack in order to test both paths when running tests, happy to change it if desired :)
🦋 Changeset detectedLatest commit: 2f5fd05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TooTallNate
reviewed
Jan 6, 2024
TooTallNate
reviewed
Jan 6, 2024
|
Thanks! |
rowaxl
pushed a commit
to yumemi-makiyama/proxy-agents
that referenced
this pull request
Jan 24, 2024
* Make decoding of base64 data URIs faster I saw in microsoft/vscode-js-debug#1911 that base64 decoding of a data URI was taking a bit of time. This PR feature-detects the presence of a global `Buffer` to use native decoding when running in Node.js, which is about 25x faster on a 10MB data URI than the JS implementation in the library. I have a bit of a hack in order to test both paths when running tests, happy to change it if desired :) * use conditional exports * fix test import * fix node test import, and set stringToBuffer encoding * Create few-adults-rhyme.md --------- Co-authored-by: Nathan Rajlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw in microsoft/vscode-js-debug#1911 that
base64 decoding of a data URI was taking a bit of time.
This PR feature-detects the presence of a global
Bufferto use nativedecoding when running in Node.js, which is about 25x faster on a 10MB
data URI than the JS implementation in the library.
I have a bit of a hack in order to test both paths when running tests,
happy to change it if desired :)