Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sampling inside gradient loop issue #183

Conversation

bekleyis95
Copy link

This MR is an extension on MR 147, where the algorithm is fixed to support sampling inside the gradient step loop instead of outside. The changes are made for all the places uses gradient step loop which diverges from the methodology outlined in the papers.

@Toni-SM Toni-SM changed the base branch from develop to main November 3, 2024 14:37
@Toni-SM Toni-SM changed the base branch from main to develop November 3, 2024 14:37
@Toni-SM Toni-SM merged commit 9252ec9 into Toni-SM:develop Nov 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants