fix: Hard-coded strings

TomBursch · Mar 16, 2024 · 7eb8009 · 7eb8009
1 parent 78b16a6
commit 7eb8009
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 8 deletions.
diff --git a/kitchenowl/lib/l10n/app_en.arb b/kitchenowl/lib/l10n/app_en.arb
@@ -70,6 +70,7 @@
   "@dangerZone": {},
   "@darkmode": {},
   "@date": {},
+  "@defaultKey": {},
   "@defaultWord": {},
   "@delete": {},
   "@description": {},
@@ -131,6 +132,7 @@
   "@householdNew": {},
   "@householdSwitch": {},
   "@households": {},
+  "@icon": {},
   "@imageSelect": {},
   "@import": {},
   "@importStartedHint": {},
@@ -210,6 +212,7 @@
   "@onboardingTitle": {},
   "@optional": {},
   "@or": {},
+  "@ordering": {},
   "@other": {},
   "@overview": {},
   "@owesAB": {
@@ -385,6 +388,7 @@
   "dangerZone": "Danger Zone",
   "darkmode": "Dark mode",
   "date": "Date",
+  "defaultKey": "Default key",
   "defaultWord": "Default",
   "delete": "Delete",
   "description": "Description",
@@ -430,6 +434,7 @@
   "householdNew": "New household",
   "householdSwitch": "Switch household",
   "households": "Households",
+  "icon": "Icon",
   "imageSelect": "Select an image",
   "import": "Import",
   "importStartedHint": "Import started, this may take a few minutes.",
@@ -486,6 +491,7 @@
   "onboardingSettingsTitle": "Hi {name}, let's set up the server!",
   "onboardingTitle": "Let's create a user",
   "optional": "Optional",
+  "ordering": "Ordering",
   "or": "or",
   "other": "Other",
   "overview": "Overview",

diff --git a/kitchenowl/lib/pages/item_page.dart b/kitchenowl/lib/pages/item_page.dart
@@ -255,22 +255,26 @@ class _ItemPageState<T extends Item> extends State<ItemPage<T>> {
                             ),
                             ListTile(
                               contentPadding: EdgeInsets.zero,
-                              title: Text("Ordering"),
+                              title:
+                                  Text(AppLocalizations.of(context)!.ordering),
                               trailing: Text(widget.item.ordering.toString()),
                             ),
+                            if (state.icon != null)
+                              ListTile(
+                                contentPadding: EdgeInsets.zero,
+                                title: Text(AppLocalizations.of(context)!.icon),
+                                trailing: Text(state.icon ?? ""),
+                              ),
                             ListTile(
                               contentPadding: EdgeInsets.zero,
-                              title: Text("Icon"),
-                              trailing: Text(state.icon ?? ""),
-                            ),
-                            ListTile(
-                              contentPadding: EdgeInsets.zero,
-                              title: Text("Default"),
+                              title: Text(
+                                  AppLocalizations.of(context)!.defaultWord),
                               trailing: Text(widget.item.isDefault.toString()),
                             ),
                             ListTile(
                               contentPadding: EdgeInsets.zero,
-                              title: Text("Default name"),
+                              title: Text(
+                                  AppLocalizations.of(context)!.defaultKey),
                               trailing: Text(widget.item.defaultKey ?? ""),
                             ),
                             const Divider(),