Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Static build on non-amd64 targets #375

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

nurupo
Copy link
Member

@nurupo nurupo commented Mar 29, 2024

This change is Reviewable

@nurupo nurupo added the chore Updating grunt tasks etc; no production code change label Mar 29, 2024
@nurupo nurupo added this to the 0.15.1 milestone Mar 29, 2024
@nurupo
Copy link
Member Author

nurupo commented Mar 29, 2024

Tested on amd64, i386 and arm64v8. Looks like it's just -fcf-protection=full that is not portable.

@nurupo nurupo requested a review from JFreegman March 29, 2024 17:11
@nurupo nurupo marked this pull request as ready for review March 29, 2024 17:11
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@pull-request-attention pull-request-attention bot assigned nurupo and unassigned JFreegman Mar 29, 2024
@toktok-releaser toktok-releaser merged commit 7b4380a into TokTok:master Mar 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Updating grunt tasks etc; no production code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants