Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Use .empty() instead of .size() == 0. #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

cleanup: Use `.empty()` instead of `.size() == 0`.

00903ea
Select commit
Loading
Failed to load commit list.
Open

cleanup: Use .empty() instead of .size() == 0. #78

cleanup: Use `.empty()` instead of `.size() == 0`.
00903ea
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Nov 22, 2024 in 2s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : cleanup: Use .empty() instead of .size() == 0.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : cleanup: Use .empty() instead of .size() == 0.
run-clang-tidy -p _build -fix \
  $(find . -name "*.h" -or -name "*.cpp" -or -name "*.c" | grep -v "/_build/") \
  -checks="-*,readability-container-*"

Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : ```sh
    run-clang-tidy -p _build -fix
    $(find . -name ".h" -or -name ".cpp" -or -name ".c" | grep -v "/_build/")
    -checks="-
    ,readability-container-*"

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/TokTok/qTox/78)
<!-- Reviewable:end -->

 Settings : ```{"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}```
<!-- #mergeable-data {"id":33378429359,"eventName":"pull_request_review","action":"submitted"} #mergeable-data -->